test: Refactor distributed job creation in testing#1482
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
itsomri
force-pushed
the
omric/unified-distributed-batch-job-helper
branch
from
42fd500 to
c536d88
Compare
|
Total coverage: 49.9% -> 49.8% Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
itsomri
force-pushed
the
omric/unified-distributed-batch-job-helper
branch
from
c536d88 to
80c9168
Compare
Signed-off-by: itsomri <omric@nvidia.com>
itsomri
force-pushed
the
omric/unified-distributed-batch-job-helper
branch
from
80c9168 to
cf48f08
Compare
1 participant
Description
Our e2e tests relied on several different helper functions to simulate jobs, distributed jobs, elastic, kwok etc. With the introduction of fine-grained minMember annotation for batch jobs, all these helpers can be consolidated, simplifying tests and potentially improving test performance, as we offload distributed pod creation to the k8s job controller instead of the test client.
Checklist
Breaking Changes
Additional Notes